Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support helm charts in kwok #1029

Open
yuanchen8911 opened this issue Apr 9, 2024 · 4 comments · May be fixed by #1060
Open

Support helm charts in kwok #1029

yuanchen8911 opened this issue Apr 9, 2024 · 4 comments · May be fixed by #1060
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v0.6

Comments

@yuanchen8911
Copy link
Member

What would you like to be added?

It would be great if KWOK could support Helm charts. I had a brief discussion with @wzshiming on Slack, and here's a summary.

The main issue arises from the conflict with the go template's {{ and }}. Since Helm charts also use these as default values, KWOK would need to support modifying the default {{ and }}. This change is straightforward but requires modification at every occurrence.

To enable coexistence between the two, there are two options:

Integrate kustomize with Helm, as detailed here: https://helm.sh/docs/topics/advanced/#post-rendering
Integrate Helm with kustomize, as detailed here: https://kubectl.docs.kubernetes.io/references/kustomize/kustomization/helmcharts
Option 2 (integrating Helm into kustomize) appears to be the more feasible solution.

@dmitsh, what are your thoughts on this?

Why is this needed?

Helm charts are widely used, making it easier to configure, create, and manage virtual clusters.
@yuanchen8911 yuanchen8911 added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 9, 2024
@yuanchen8911
Copy link
Member Author

cc @wzshiming @dmitsh Created an issue on helm support.

@dmitsh
Copy link
Contributor

dmitsh commented Apr 9, 2024

Could you elaborate about the conflict with the go template?

@dmitsh
Copy link
Contributor

dmitsh commented Apr 9, 2024

Regardless, we are using ArgoCD to automate deployments of components with Helm. The goal is to deploy all the components without user intervention or input.

@yuanchen8911
Copy link
Member Author

Could you elaborate about the conflict with the go template?

I think what Shiming referenced to was a helm template needs additional {{ }} in a stage's statusTemplate.

 next:
   statusTemplate: |
     {{`

    `}}

@dmitsh dmitsh linked a pull request May 3, 2024 that will close this issue
Open
@wzshiming wzshiming added this to the v0.6 milestone May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
KWOK Tracking
Status: 🆕 New
Milestone
v0.6
Development

Successfully merging a pull request may close this issue.

feature: added helm support dmitsh/kwok
3 participants
@wzshiming @dmitsh @yuanchen8911