WIP: Additional Kueue performance metrics #481
Conversation
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: oginskis The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @oginskis. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/M
|
/assign @alculquicondor |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
| @@ -76,7 +76,27 @@ steps: | |||
| - name: perc_90_pod_waiting_time | |||
| query: quantile(0.90, kube_pod_start_time{namespace=~"{{$namespacePrefix}}.*"} - kube_pod_created{namespace=~"{{$namespacePrefix}}.*"}) | |||
| - name: max_job_throughput | |||
| query: max_over_time(sum(rate(kueue_admitted_workloads_total{cluster_queue="{{$clusterQueue}}"}[1m]))[{{$testTimeout}}:5s]) | |||
| query: max_over_time(sum(rate(kueue_admitted_workloads_total{cluster_queue="{{$clusterQueue}}"}[1m]))[{{$testTimeout}}:5s]) | |||
| - Identifier: GenericPrometheusQueryAdditional | |||
There was a problem hiding this comment.
Use a name that reflects what these queries have in common.
| @@ -178,4 +198,11 @@ steps: | |||
| Method: GenericPrometheusQuery | |||
| Params: | |||
| action: gather | |||
| enableViolations: true | |||
| enableViolations: true | |||
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
/help |
|
/remove-lifecycle stale |
k8s-ci-robot
removed
the
lifecycle/stale
|
@mcariatm could you pick this up? |
ok |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
/assign trasc |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
k8s-ci-robot
added
lifecycle/rotten
|
@oginskis: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@gabesaba do you think we should revive this PR? |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The PR contains additional performance measurements based on Kueue Prometheus metrics:
kueue_admission_attempt_duration_seconds_sum{result="success"}/kueue_admission_attempt_duration_seconds_count{result="success"}inadmissibleattempt duration:kueue_admission_attempt_duration_seconds_sum{result="inadmissible"}/kueue_admission_attempt_duration_seconds_count{result="inadmissible"}histogram_quantile(0.90, sum(rate(kueue_admission_attempt_duration_seconds_bucket{result="success"}[{{$testTimeout}}])) by (le))inadmissibleattempt duration:histogram_quantile(0.90, sum(rate(kueue_admission_attempt_duration_seconds_bucket{result="inadmissible"}[{{$testTimeout}}])) by (le))kueue_admission_wait_time_seconds_sum / kueue_admission_wait_time_seconds_counthistogram_quantile(0.90, sum(rate(kueue_admission_wait_time_seconds_bucket[{{$testTimeout}}])) by (le))ToDos:
summary.csv)