Remove gci linter because it breaks import comments

[alexandear]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Removes gci from the linter-settings golangci-lint's config because it's does nothing. This reverts #2069.

Special notes for your reviewer:

Adding gci to linters-settings has no effect. This can be checked by running golangci-lint in verbose mode (see "Active 14 linters"):

❯ golangci-lint run -v
INFO [config_reader] Config search paths: [./ /Users/Oleksandr_Redko/src/github.com/kubernetes-sigs/kueue /Users/Oleksandr_Redko/src/github.com/kubernetes-sigs /Users/Oleksandr_Redko/src/github.com /Users/Oleksandr_Redko/src /Users/Oleksandr_Redko /Users /] 
INFO [config_reader] Used config file .golangci.yaml 
INFO [lintersdb] Active 14 linters: [copyloopvar dupword errcheck ginkgolinter gocritic goimports gosimple govet ineffassign loggercheck misspell staticcheck unconvert unused] 
INFO [loader] Go packages loading at mode 575 (compiled_files|exports_file|files|imports|name|deps|types_sizes) took 893.271667ms 
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 28.035667ms 

To enable gci, it's needed to extend linters.enable list:

linters:
  enable:
    - ...
    - dupword
    - gci
    - ginkgolinter
    - ...

However, enabling gci can lead to some problems. gci removes the comments // +kubebuilder:scaffold:imports. This can be confirmed by running golangci-lint run --enable=gci --fix and observing the diff. Additionally, we already use goimports, which is also designed to sort imports.

Does this PR introduce a user-facing change?

NONE

[k8s-ci-robot]

Hi @alexandear. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	ced804b
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/664217fecef5d60008de6468

[tenzen-y]

/ok-to-test

[mimowo]

I agree it does not make sense to keep the configuration for GCI if we are not enabling it.

However, I'm yet wondering about the pros and cons of GCI vs goimports. Maybe we could configure GCI so that there is no issue with removing // +kubebuilder:scaffold:imports?

[alexandear]

@mimowo, you're absolutely correct about using gci instead of goimports. gci is more powerful.

Initially, I attempted to configure gci to prevent it from removing the comments. However, this was impossible. See the bug daixiang0/gci#135.

[mimowo]

I see, in that case I'm ok to drop the config for now (as it makes the impression this is enabled).
We can return to re-enabling once the issue is fixed and the new version of gci is available.
/lgtm
/assign @tenzen-y

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 6bf4ba24817bf7ace15f1d4e06989c64ed08bec7

[tenzen-y]

@alexandear Thank you for investigating the issue.
Could you dedicate an issue to keep track of GCI issues?

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexandear, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alexandear]

Could you dedicate an issue to keep track of GCI issues?

Created #2198