Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kueuectl] Pass-through commands. #2181

Merged
merged 3 commits into from May 20, 2024
Merged

[kueuectl] Pass-through commands. #2181

merged 3 commits into from May 20, 2024

Conversation

trasc
Copy link
Contributor

@trasc trasc commented May 10, 2024 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add pass-through commands support in kueuectl.

Which issue(s) this PR fixes:

Fixes #2180

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added pass-through commands support in `kueuectl` for `get`, `describe`, `edit`, `patch` and `delete`.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 10, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 10, 2024
@netlify Netlify
Copy link

netlify bot commented May 10, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit e8aa853
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6646f9c7166935000897544a

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 14, 2024
@trasc
Copy link
Contributor Author

trasc commented May 14, 2024

/test all

@trasc
Copy link
Contributor Author

trasc commented May 14, 2024

/test pull-kueue-test-integration-main

@trasc
Copy link
Contributor Author

trasc commented May 14, 2024

/retest

@trasc
Copy link
Contributor Author

trasc commented May 14, 2024

/retest

@trasc trasc changed the title [WIP][kueuectl] Pass-through commands. [kueuectl] Pass-through commands. May 14, 2024
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 14, 2024
@trasc trasc marked this pull request as ready for review May 14, 2024 09:49
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2024
@trasc
Copy link
Contributor Author

trasc commented May 14, 2024

/cc @mwielgus

@mbobrovskyi
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3949ac6b943513570149d1648838407844b478d9

@mbobrovskyi
Copy link
Contributor

/assign @alculquicondor

alculquicondor
alculquicondor reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold to reduce integration tests.

test/integration/kueuectl/passthrough_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2024
@mbobrovskyi
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6be3a1abd3f1ca29269e71578af30af651f54c3b

@mbobrovskyi
Copy link
Contributor

/test pull-kueue-test-integration-main

@k8s-ci-robot k8s-ci-robot merged commit 703be5f into kubernetes-sigs:main May 20, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone May 20, 2024
@trasc trasc deleted the kueuectl-pass-through branch May 23, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@kerthcet kerthcet Awaiting requested review from kerthcet

@denkensk denkensk Awaiting requested review from denkensk

@mwielgus mwielgus Awaiting requested review from mwielgus

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@mbobrovskyi mbobrovskyi Awaiting requested review from mbobrovskyi

Assignees

@alculquicondor alculquicondor

@mbobrovskyi mbobrovskyi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

[kueuectl] Add Pass-through commands
5 participants
@trasc @k8s-ci-robot @mbobrovskyi @alculquicondor @tenzen-y