Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

servicemonitorCRD is need before install prometheus.yaml #2162

Merged
merged 2 commits into from May 22, 2024
Merged

servicemonitorCRD is need before install prometheus.yaml #2162

merged 2 commits into from May 22, 2024

Conversation

lowang-bh
Copy link
Member

@lowang-bh lowang-bh commented May 8, 2024 •
edited

There will be an error if servicemonitorCRD not installed :
no matches for kind "ServiceMonitor" in version "monitoring.coreos.com/v1" ensure CRDs are installed first

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2085

Special notes for your reviewer:

Does this PR introduce a user-facing change?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 8, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 8, 2024
@netlify Netlify
Copy link

netlify bot commented May 8, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 76fd8d6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/664db38394f94c00087abe22

@lowang-bh lowang-bh changed the title servicemonitorCustomResourceDefinition is need before install prometh… servicemonitorCRD is need before install promethuse.yaml May 8, 2024
@lowang-bh lowang-bh changed the title servicemonitorCRD is need before install promethuse.yaml servicemonitorCRD is need before install prometheus.yaml May 8, 2024
@tenzen-y
Copy link
Member

tenzen-y commented May 9, 2024

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 9, 2024
@lowang-bh
servicemonitorCustomResourceDefinition is need before install prometh…
80f0fb5 
…eus.yaml

Signed-off-by: lowang-bh <lhui_wang@163.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 22, 2024 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 22, 2024
@lowang-bh @tenzen-y
Update site/content/en/docs/installation/_index.md
76fd8d6 
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: lowang-bh <lhui_wang@163.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 22, 2024
@tenzen-y
Copy link
Member

/easycla

tenzen-y
tenzen-y reviewed May 22, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you!
/lgtm
/approve
/cherry-pick website

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3259953baf1cdbfd6e09ee5d73eb695fa7a65ce4

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lowang-bh, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2024
@tenzen-y
Copy link
Member

/cherry-pick website

@k8s-infra-cherrypick-robot
Copy link

@tenzen-y: once the present PR merges, I will cherry-pick it on top of website in a new PR and assign it to you.

In response to this:

/cherry-pick website

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 6aede82 into kubernetes-sigs:main May 22, 2024
6 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone May 22, 2024
@k8s-infra-cherrypick-robot
Copy link

@tenzen-y: new pull request created: #2259

In response to this:

/cherry-pick website

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@denkensk denkensk Awaiting requested review from denkensk

@trasc trasc Awaiting requested review from trasc

Assignees

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

ServiceMonitor CRD should be installed first before apply prometheus.yaml
4 participants
@lowang-bh @tenzen-y @k8s-ci-robot @k8s-infra-cherrypick-robot