Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kueuectl] Add list LocalQueue command. #2157

Merged
merged 2 commits into from May 13, 2024
Merged

[kueuectl] Add list LocalQueue command. #2157

merged 2 commits into from May 13, 2024

Conversation

mbobrovskyi
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

To get list LocalQueues that match the given criteria: point to a specific CQ, being active/inactive, belonging to the specified namespace or matching the label selector.

Which issue(s) this PR fixes:

Fixes #2115

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add list LocalQueue command on kueuectl

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels May 8, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 8, 2024
@netlify Netlify
Copy link

netlify bot commented May 8, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 9643157
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66421cb5a8ff2d0008a378c5

@mbobrovskyi
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 8, 2024
@mbobrovskyi mbobrovskyi marked this pull request as ready for review May 8, 2024 05:44
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2024
@mbobrovskyi
Copy link
Contributor Author

/cc @alculquicondor @mwielgus

@k8s-ci-robot k8s-ci-robot requested a review from mwielgus May 8, 2024 05:44
@mbobrovskyi
Copy link
Contributor Author

/test pull-kueue-test-integration-main

@mbobrovskyi
Copy link
Contributor Author

/assign @trasc

@mbobrovskyi
Copy link
Contributor Author

Created another PR #2157 to fix integration tests.

@mbobrovskyi
Copy link
Contributor Author

Also about active/inactive filter, we will add it on the next follow up after finished #2109.

@mbobrovskyi mbobrovskyi force-pushed the feature/list-localqueue-command branch 2 times, most recently from fe72677 to 36b2203 Compare May 8, 2024 09:09
trasc
trasc reviewed May 8, 2024
View reviewed changes
cmd/kueuectl/app/list/list_localqueue.go Show resolved Hide resolved
cmd/kueuectl/app/list/list_localqueue.go Show resolved Hide resolved
cmd/kueuectl/app/list/list_localqueue.go Outdated Show resolved Hide resolved
cmd/kueuectl/app/list/list_localqueue.go Outdated Show resolved Hide resolved
@mbobrovskyi mbobrovskyi force-pushed the feature/list-localqueue-command branch from d560580 to 9e40be7 Compare May 8, 2024 18:52
@vladikkuzn
Copy link
Contributor

vladikkuzn commented May 8, 2024 •
edited

@mwielgus I wonder why is it named list? Maybe we should adjust KEP and following PRs and rename it to get so that it corresponds with k8s: https://github.com/kubernetes/kubernetes/blob/132c49c40b5ef7d3b9ca822774b0c56d12e2d14f/staging/src/k8s.io/kubectl/pkg/cmd/get/get.go#L173

For me right now it looks like it's totally the same as get command with field-selector and/or jq added for flags provided by kueuectl

p.s. We can create a suggestions for list and ps

@mbobrovskyi
Copy link
Contributor Author

/test pull-kueue-test-e2e-main-1-28

trasc
trasc reviewed May 10, 2024
View reviewed changes
cmd/kueuectl/app/list/list_localqueue.go Outdated Show resolved Hide resolved
cmd/kueuectl/app/list/list_localqueue.go Show resolved Hide resolved
cmd/kueuectl/app/list/list_localqueue.go Show resolved Hide resolved
cmd/kueuectl/app/list/list_localqueue.go Show resolved Hide resolved
cmd/kueuectl/app/list/list_localqueue.go Outdated Show resolved Hide resolved
@mbobrovskyi mbobrovskyi force-pushed the feature/list-localqueue-command branch 2 times, most recently from 25c7661 to b96015a Compare May 10, 2024 10:14
trasc
trasc reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 00ce31ac029253cae98255e138591983e6fa2b34

@mbobrovskyi
Copy link
Contributor Author

/assign @alculquicondor

@mbobrovskyi mbobrovskyi force-pushed the feature/list-localqueue-command branch from b96015a to 0d1bf9b Compare May 10, 2024 17:35
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2024
@k8s-ci-robot k8s-ci-robot requested a review from trasc May 10, 2024 17:35
@mbobrovskyi mbobrovskyi force-pushed the feature/list-localqueue-command branch from 0d1bf9b to a701a35 Compare May 13, 2024 01:49
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 13, 2024
alculquicondor
alculquicondor reviewed May 13, 2024
View reviewed changes
cmd/kueuectl/app/util/factory.go Outdated
return nil, err
}

clientset, err := versioned.NewForConfig(config)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not store the clientset?

cmd/kueuectl/app/util/factory.go Outdated Show resolved Hide resolved
@mbobrovskyi mbobrovskyi force-pushed the feature/list-localqueue-command branch from a701a35 to 9643157 Compare May 13, 2024 13:59
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 13, 2024
alculquicondor
alculquicondor reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3c3da0f3f0fa30556da96de76d74a0a5e52acee4

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mbobrovskyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5d9c711 into kubernetes-sigs:main May 13, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone May 13, 2024
@mbobrovskyi mbobrovskyi deleted the feature/list-localqueue-command branch May 13, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@mwielgus mwielgus mwielgus left review comments

@vladikkuzn vladikkuzn vladikkuzn left review comments

@mimowo mimowo Awaiting requested review from mimowo

@denkensk denkensk Awaiting requested review from denkensk

@trasc trasc Awaiting requested review from trasc

Assignees

@alculquicondor alculquicondor

@trasc trasc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

[kueuectl] Add list LocalQueue command
6 participants
@mbobrovskyi @k8s-ci-robot @vladikkuzn @mwielgus @alculquicondor @trasc