Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kueuectl] List cluster queues #2156

Merged
merged 2 commits into from May 14, 2024
Merged

[kueuectl] List cluster queues #2156

merged 2 commits into from May 14, 2024

Conversation

vladikkuzn
Copy link
Contributor

@vladikkuzn vladikkuzn commented May 8, 2024 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds kueuectl list clusterqueues command to kueuectl

Which issue(s) this PR fixes:

Fixes #2114

Special notes for your reviewer:

Does this PR introduce a user-facing change?

List ClusterQueue (`kueuectl list clusterqueue`) command is available

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 8, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 8, 2024
@vladikkuzn
Copy link
Contributor Author

/assign

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 8, 2024
@netlify Netlify
Copy link

netlify bot commented May 8, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit a76f4a5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66430e29b6e50f0008d1eeb6
😎 Deploy Preview https://deploy-preview-2156--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 9, 2024
@vladikkuzn vladikkuzn force-pushed the kueuectl-list-cq branch 2 times, most recently from 8236ecf to ba62754 Compare May 9, 2024 19:00
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 9, 2024
@vladikkuzn vladikkuzn force-pushed the kueuectl-list-cq branch 2 times, most recently from 8e52476 to d085217 Compare May 9, 2024 19:08
@vladikkuzn
Copy link
Contributor Author

/ok-to-test
/assign

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 9, 2024
mbobrovskyi
mbobrovskyi reviewed May 9, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2024
@vladikkuzn vladikkuzn force-pushed the kueuectl-list-cq branch 2 times, most recently from 15006bf to 67faf16 Compare May 13, 2024 00:15
@vladikkuzn vladikkuzn force-pushed the kueuectl-list-cq branch 2 times, most recently from 58108cd to ad70ea2 Compare May 13, 2024 07:13
alculquicondor
alculquicondor reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase
/approve

site/content/en/docs/reference/kubectl-kueue/reference/list/clusterqueue.md Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, vladikkuzn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 13, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 14, 2024
@vladikkuzn vladikkuzn force-pushed the kueuectl-list-cq branch 2 times, most recently from 74ff5c3 to 92ea2f1 Compare May 14, 2024 01:23
@vladikkuzn
[kueuectl] List cluster queues
a76f4a5 
* BoolSliceVar for active filter
* Remove kubectl dep
* avoid caching contexts
* split gotOut in test
@mbobrovskyi
Copy link
Contributor

/test pull-kueue-test-integration-main

trasc
trasc reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c5aaca32b74111870f4bef2626480fdb8cf20215

@k8s-ci-robot k8s-ci-robot merged commit 5f455b0 into kubernetes-sigs:main May 14, 2024
14 of 15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbobrovskyi mbobrovskyi mbobrovskyi left review comments

@trasc trasc trasc left review comments

@denkensk denkensk Awaiting requested review from denkensk

@kerthcet kerthcet Awaiting requested review from kerthcet

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

Assignees

@vladikkuzn vladikkuzn

@trasc trasc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

[kueuectl] Add list ClusterQueue command
5 participants
@vladikkuzn @k8s-ci-robot @mbobrovskyi @alculquicondor @trasc