Adjust base timeouts for integration and E2E tests #1919
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
approved
|
/assign @tenzen-y |
k8s-ci-robot
added
the
size/XS
❌ Deploy Preview for kubernetes-sigs-kueue failed.
|
|
For some cases, it seems that we need to use the long timeout based on the result of CI. |
Change-Id: I4269e45313d0d058bec1157f6813eb0f425a6289
alculquicondor
force-pushed
the
test-timeouts
branch
from
b31f397
to
719cb58
Compare
k8s-ci-robot
added
size/M
| @@ -237,21 +237,9 @@ var _ = ginkgo.Describe("Pod groups", func() { | |||
| gomega.Expect(k8sClient.Create(ctx, excess)).To(gomega.Succeed()) | |||
| }) | |||
| ginkgo.By("Use events to observe the excess pods are getting stopped", func() { | |||
| preemptedPods := sets.New[types.NamespacedName]() | |||
| gomega.Eventually(func(g gomega.Gomega) sets.Set[types.NamespacedName] { | |||
There was a problem hiding this comment.
This implementation only processed one event every 250ms
k8s-ci-robot
added
do-not-merge/hold
|
LGTM label has been added. Git tree hash: 1a058ac9a444c484f930422ca841551ff132e1e1
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
2/3 /test pull-kueue-test-integration-main |
|
3/3 /test pull-kueue-test-integration-main /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Based on experience fixing flaky tests, a timeout of 30s just adds to development time.
If Kueue doesn't react within 5 seconds, it likely won't in a longer time.
And for operations which require multiple pieces to interact (mainly E2E tests), we still have the
LongTimeoutvariable which can be used on a case-by-case basis.The duration for Consistent checks can also be limited, as these are more of sanity checks. We try not to use these checks.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?