Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ProvisioningRequest documentation by adding a new way of passing Parameters to ProvisioningRequest #1918

Merged
merged 1 commit into from Mar 28, 2024
Merged

Update ProvisioningRequest documentation by adding a new way of passing Parameters to ProvisioningRequest #1918

merged 1 commit into from Mar 28, 2024

Conversation

PBundyra
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1788

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels Mar 26, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 26, 2024
@PBundyra
Copy link
Contributor Author

/assign @alculquicondor

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 26, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 26, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 28c58cb
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6605652373b2840008cfe467
😎 Deploy Preview https://deploy-preview-1918--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 27, 2024
alculquicondor
alculquicondor reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use "job" when referring to jobs generically. We use Job when referring to the k8s Job.

We might say Kubernetes Job or batch/v1 Job when we really want to refer to them specifically.

site/content/en/docs/admission-check-controllers/provisioning.md Outdated Show resolved Hide resolved
site/content/en/docs/admission-check-controllers/provisioning.md Outdated Show resolved Hide resolved
site/content/en/docs/admission-check-controllers/provisioning.md Outdated Show resolved Hide resolved
site/content/en/docs/admission-check-controllers/provisioning.md Outdated Show resolved Hide resolved
site/content/en/docs/admission-check-controllers/provisioning.md Outdated Show resolved Hide resolved
alculquicondor
alculquicondor reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok last nits :)

site/content/en/docs/admission-check-controllers/provisioning.md Outdated Show resolved Hide resolved
site/content/en/docs/admission-check-controllers/provisioning.md Outdated Show resolved Hide resolved
@alculquicondor
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3e77b8af5c4791505d0b44d57be4d3905f99775c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, PBundyra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2024
@k8s-ci-robot k8s-ci-robot merged commit a5fb2d6 into kubernetes-sigs:main Mar 28, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone Mar 28, 2024
vsoch pushed a commit to researchapps/kueue that referenced this pull request Apr 18, 2024
@PBundyra @vsoch
Update Provision AdmissionCheck documentation (kubernetes-sigs#1918)
0bb7814
@PBundyra PBundyra deleted the provreq-doc-update branch April 26, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@denkensk denkensk Awaiting requested review from denkensk

@trasc trasc Awaiting requested review from trasc

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

A mechanism to pass parameters to ProvisioningRequest
3 participants
@PBundyra @alculquicondor @k8s-ci-robot