Fix Pod finalizers for succeeded groups #1905
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
approved
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alculquicondor
force-pushed
the
fix-pod-finalize
branch
from
76993cb
to
24ca225
Compare
Change-Id: I7f17d51df66de6766af44e48f45b4165e8bd3e30
alculquicondor
force-pushed
the
fix-pod-finalize
branch
from
24ca225
to
b59df4c
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| if err := r.finalizeJob(ctx, job); err != nil { | ||
| return ctrl.Result{}, err | ||
| } |
There was a problem hiding this comment.
Since this PR, we always finalize the Job when the Job has WorkloadFinished condition.
So, is this workload-controller mechanism still needed?
kueue/pkg/controller/core/workload_controller.go
Lines 158 to 160 in 5023dd2
There was a problem hiding this comment.
It still helps in the case of a rogue user manually deleting finalizers.
But I'm also never sure which cases we are missing when dealing with finalizers. So I prefer to keep it.
There was a problem hiding this comment.
That makes sense.
Thank you for the clarification!
/lgtm
|
/cherry-pick release-0.6 |
|
@alculquicondor: once the present PR merges, I will cherry-pick it on top of release-0.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 7cd9ff8e054e24d92b08bacc57feb6e3349a5703
|
|
Let's do a few runs 1/5 passed. /test pull-kueue-test-integration-main |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/cherry-pick website |
|
@alculquicondor: once the present PR merges, I will cherry-pick it on top of website in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Oops, I put the |
|
2/5 passed. /test pull-kueue-test-integration-main |
|
3/5 passed. /test pull-kueue-test-integration-main |
|
4/5 passed. /test pull-kueue-test-integration-main |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@alculquicondor: new pull request created: #1908 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@alculquicondor: new pull request created: #1909 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-0.6 |
|
@alculquicondor: new pull request created: #1916 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Change-Id: I7f17d51df66de6766af44e48f45b4165e8bd3e30
What type of PR is this?
/kind bug
What this PR does / why we need it:
The initial attempt to clear finalizers after declaring a Workload as finished might fail partially. At this point, some succeeded pods might be gone, so the group can no longer be interpreted as finished. But we shouldn't be checking that again.
Which issue(s) this PR fixes:
Fixes #1898
Special notes for your reviewer:
Does this PR introduce a user-facing change?