Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to golang 1.22 #1895

Merged
merged 1 commit into from Mar 25, 2024
Merged

Conversation

kannon92
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Bump golang to 1.22.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Testing this right now. kubernetes-sigs/jobset#471 is open but failing for some infrastructure issues.

Want to confirm if its limited to image.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 25, 2024
@kannon92
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2024
Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit fb0af83
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66017f0c5bdd3c0008fb1ccd
😎 Deploy Preview https://deploy-preview-1895--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tenzen-y
Copy link
Member

+1
Actually, I discussed this at #1872 (comment).

@kannon92
Copy link
Contributor Author

Okay. I'll open a test-infra PR to add golang 1.22.

@kannon92
Copy link
Contributor Author

Opened kubernetes/test-infra#32301

@kannon92
Copy link
Contributor Author

/retest

@alculquicondor
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7fddd3a6f2026256923153be8e0c301cd7cf5184

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@kannon92
Copy link
Contributor Author

/hold cancel

CI looks good to go.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6d45624 into kubernetes-sigs:main Mar 25, 2024
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone Mar 25, 2024
vsoch pushed a commit to researchapps/kueue that referenced this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants