[importer] Extend mapping capabilities. #1878
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
added
the
size/XL
|
|
||
| - During the mapping, if the match rule has no `priorityClassName` the `priorityClassName` of the pod will be ignored, if more than one `label: value` pairs are provided, all of them should match. | ||
| - The rules are evaluated in order. | ||
| - `skip: true` can be used to ignore the pods matching a rule. |
There was a problem hiding this comment.
could the user leave a rule with no priorityClassName and no labels with skip:true?
That could be a way of saying: if it doesn't match any rule above, I just don't care about this pod.
There was a problem hiding this comment.
yes,
-skip: trueat the end is doing that.
similarly
-toLocalQueue: user-queue2will put all the pods in one localQueue
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: cf2840134bd0ea1efadc0884286ff721592f5384
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| ``` | ||
|
|
||
| ```bash | ||
| ./bin/importer import -n ns1,ns2 --queuemapping-file=<mapping-file-path> --dry-run=false |
There was a problem hiding this comment.
Could script return done or smth if the import finished successfully?
* [cmd/importer] Advanced mapping. * [cmd/importer] Add skip. * Review Remarks
What type of PR is this?
/kind feature
What this PR does / why we need it:
[importer] Extend mapping capabilities.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?