MultiKueue JobSet managedBy #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
trasc
force-pushed
the
multikueue-jobset-managed-by
branch
from
48e809d
to
2b25e98
Compare
mimowo
reviewed
Mar 20, 2024
mimowo
reviewed
Mar 25, 2024
|
/hold |
k8s-ci-robot
added
do-not-merge/hold
trasc
force-pushed
the
multikueue-jobset-managed-by
branch
from
2b25e98
to
df80ffb
Compare
k8s-ci-robot
removed
the
needs-rebase
trasc
force-pushed
the
multikueue-jobset-managed-by
branch
2 times, most recently
from
f8752a6
to
21142b9
Compare
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
trasc
force-pushed
the
multikueue-jobset-managed-by
branch
from
21142b9
to
5c69f9f
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 5fc7622b2e3abc96d956242b83803c311396cc22
|
|
/unassign @mimowo can you handle this one? |
I think extra approve will be needed for docs, but I can approve the rest. |
mimowo
reviewed
Apr 16, 2024
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: f7fb744a7e9a8aee5175e456fa919aba2a27958d
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, mimowo, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
tenzen-y
reviewed
Apr 16, 2024
| @@ -101,3 +101,7 @@ func (b *batchJobAdapter) DeleteRemoteObject(ctx context.Context, remoteClient c | |||
| func (b *batchJobAdapter) KeepAdmissionCheckPending() bool { | |||
| return true | |||
| } | |||
|
|
|||
| func (b *batchJobAdapter) IsJobManagedByKueue(_ context.Context, _ client.Client, _ types.NamespacedName) (bool, string, error) { | |||
There was a problem hiding this comment.
Suggested change
| func (b *batchJobAdapter) IsJobManagedByKueue(_ context.Context, _ client.Client, _ types.NamespacedName) (bool, string, error) { | |
| func (b *batchJobAdapter) IsJobManagedByKueue(context.Context, client.Client, types.NamespacedName) (bool, string, error) { |
This is a minor nit.
There was a problem hiding this comment.
We should have the managedBy field available for Jobs soon and we'll need to properly implement the method.
vsoch
pushed a commit
to researchapps/kueue
that referenced
this pull request
Apr 18, 2024
* [multikueue] Reject Workload with unsupported owner type. * [multikueue/jobset] Use `mabagedBy` field support. * Review Remarks. * Review Remarks * Review remarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add support for JobSet
spec.managedBy.Which issue(s) this PR fixes:
Fixes #693
Special notes for your reviewer:
Does this PR introduce a user-facing change?