Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update verify shellcheck to reduce the time to less than 15min #1863

Merged
merged 2 commits into from Mar 19, 2024
Merged

update verify shellcheck to reduce the time to less than 15min #1863

merged 2 commits into from Mar 19, 2024

Conversation

Vandit1604
Copy link
Contributor

@Vandit1604 Vandit1604 commented Mar 17, 2024 •
edited by alculquicondor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR addresses verify rule taking more than 15 mins in Prow test suite.

Which issue(s) this PR fixes:

Part of #1849

Special notes for your reviewer:

For more info, see #1849 (comment)

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 17, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 17, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Vandit1604. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 17, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 17, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 621a636
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65f8b14ed96c550008d576ae

@alculquicondor
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 18, 2024
alculquicondor
alculquicondor reviewed Mar 18, 2024
View reviewed changes
hack/verify-shellcheck.sh Outdated
# Currently disabled these errors will take care of them later
DISABLED_ERRORS="SC2002,SC3028,SC3054,SC3014,SC3040,SC3046,SC3030,SC3010,SC3037,SC3045,SC3006,SC3018,SC3016,SC3011,SC3044,SC3043,SC3060,SC3024,SC1091,SC2066,SC2086,SC2034,SC1083,SC1009,SC1073,SC1072,SC2155,SC2046"
SHELLCHECK_DISABLED="SC2002,SC3028,SC3054,SC3014,SC3040,SC3046,SC3030,SC3010,SC3037,SC3045,SC3006,SC3018,SC3016,SC3011,SC3044,SC3043,SC3060,SC3024,SC1091,SC2066,SC2086,SC2034,SC1083,SC1009,SC1073,SC1072,SC2155,SC2046"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this variable be defined before line 25?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@alculquicondor
Copy link
Contributor

while this is faster, verify is still taking more than 10 min

Maybe there are more things we can do in other verifications.

@Vandit1604
Copy link
Contributor Author

Vandit1604 commented Mar 18, 2024 •
edited

Is there a way to check how much time a rule is taking? I tried adding time command to each rule's definition, but it failed with golangci-lint. I also checked in k/k's Makefile to see in which rule do they use shell check, but they don't use it in any of the rules.

Furthermore, I'll check other verifications tomorrow.

@alculquicondor
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, Vandit1604

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ce28e080d3cb7aa80fbf28cbcca9fcc7161862d9

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0d82048 into kubernetes-sigs:main Mar 19, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone Mar 19, 2024
@Vandit1604 Vandit1604 deleted the fix/inspect-verify-main branch March 19, 2024 20:34
alexandear
alexandear reviewed Mar 20, 2024
View reviewed changes
hack/verify-shellcheck.sh
# set colorized output
"--color=${SHELLCHECK_COLORIZED_OUTPUT}"
)

# Currently disabled these errors will take care of them later
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should move this comment to line 23.

vsoch pushed a commit to researchapps/kueue that referenced this pull request Apr 18, 2024
@Vandit1604 @vsoch
update verify shellcheck to reduce the time to less than 15min (kuber…
61005d2 
…netes-sigs#1863)

* update verify shellcheck to reduce the time to less than 15min

* put disabled_errors on the correct line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@alexandear alexandear alexandear left review comments

@denkensk denkensk Awaiting requested review from denkensk

@trasc trasc Awaiting requested review from trasc

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Vandit1604 @k8s-ci-robot @alculquicondor @alexandear