Dynamically Sized Jobs - Scale Down #1852
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @vicentefb. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/L
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vicentefb
force-pushed
the
ElasticJobs
branch
2 times, most recently
from
f0f98d9
to
d49df00
Compare
vicentefb
force-pushed
the
ElasticJobs
branch
2 times, most recently
from
0bcee5e
to
daa8d26
Compare
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
andrewsykim
reviewed
Mar 18, 2024
k8s-ci-robot
added
size/XL
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vicentefb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/L
vicentefb
force-pushed
the
ElasticJobs
branch
2 times, most recently
from
b194b89
to
35ca648
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
vicentefb
force-pushed
the
ElasticJobs
branch
4 times, most recently
from
b8255b9
to
0d65f24
Compare
test/integration/controller/jobs/raycluster/raycluster_controller_test.go
Show resolved
Hide resolved
andrewsykim
reviewed
Apr 12, 2024
k8s-ci-robot
added
the
needs-rebase
vicentefb
force-pushed
the
ElasticJobs
branch
2 times, most recently
from
60cbf6b
to
def03e9
Compare
k8s-ci-robot
removed
the
needs-rebase
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
andrewsykim
reviewed
Apr 30, 2024
andrewsykim
reviewed
Apr 30, 2024
k8s-ci-robot
added
the
needs-rebase
|
/cc |
n m patch error field not declared in schema commented out podSet immutability from workload webhook to be able to update that field added more comments clean code nit debuggin n m patch error field not declared in schema clean code n m patch error field not declared in schema commented out podSet immutability from workload webhook to be able to update that field added more comments clean code nit a cluster queue reconciliation fixed, it had to do with the infot totalrequests from admission inside the worklad go file working with scheduler cleaning code cleaning code cleaning cleaning cleaning integation test, but it messes up with parallelism test which should be expected updated parallelism it test updated wrappers kep removed Kep removed log lines clean code added a better conditional for updating the resize if the job is a RayCluster added Kind condition updated test and equivalentToWorkload condition added podset assigments check updated feature gate updated feature gate updating equivalentWorkload fixed lint removed changes from scheduler and workload controller testing updated workload controller reconciler to update spec and status nit update feature gate update variables made code more generic updated workload controller helper method typo nit addressed comments updated workload controller to use unuused quota updated integration test to work added unit test in workload controller changed naming to resizeable and fixed lint nit addressed comments
|
/retest |
k8s-ci-robot
removed
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This includes Phase 1 implementation for Dynamically Sized Jobs KEP #1851
Which issue(s) this PR fixes:
Part of #77
Special notes for your reviewer:
Scale Down only implementation for RayClusters
Does this PR introduce a user-facing change?