Fix number of reconcilers for Pod integration #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: If8f430731a6967a361d0f5172ed408f57a0687bc
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 98f059704ecd982913c6eabcd1f8b211a3559222
|
|
/cherry-pick release-0.6 |
|
@alculquicondor: new pull request created: #1837 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
vsoch
pushed a commit
to researchapps/kueue
that referenced
this pull request
Apr 18, 2024
Change-Id: If8f430731a6967a361d0f5172ed408f57a0687bc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
There were 2 problems:
For, which controller-runtime uses to map to groupKindConcurrency.Pod, notPod..Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Thanks to @gabesaba for spotting the problem.
It's not easy to test this issue, but I did a manual run to verify the number of reconcilers.
Does this PR introduce a user-facing change?