Avoid requeue on ClusterQueue status update #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
approved
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
added
the
size/M
tenzen-y
reviewed
Mar 11, 2024
alculquicondor
force-pushed
the
avoid-requeue
branch
3 times, most recently
from
404a3cc
to
de415e6
Compare
Change-Id: Id028414a730a238549b7fddf5d42a2eafdf959c3
alculquicondor
force-pushed
the
avoid-requeue
branch
from
de415e6
to
3e88ef3
Compare
Change-Id: Id52ef3c92abd84317c4a7a71c3a20f6f28d67d25
alculquicondor
force-pushed
the
avoid-requeue
branch
from
a042df7
to
1e66b43
Compare
tenzen-y
reviewed
Mar 11, 2024
| @@ -119,6 +119,7 @@ func (c *clusterQueueBase) PushOrUpdate(wInfo *workload.Info) { | |||
| // to potentially become admissible, unless the Eviction status changed | |||
| // which can affect the workloads order in the queue. | |||
| if equality.Semantic.DeepEqual(oldInfo.Obj.Spec, wInfo.Obj.Spec) && | |||
| equality.Semantic.DeepEqual(oldInfo.Obj.Status.ReclaimablePods, wInfo.Obj.Status.ReclaimablePods) && | |||
There was a problem hiding this comment.
Should we extend this UT:
kueue/pkg/queue/cluster_queue_impl_test.go
Line 228 in 1e66b43
|
/test pull-kueue-test-integration-main |
alculquicondor
force-pushed
the
avoid-requeue
branch
from
a43db01
to
1b243b3
Compare
Change-Id: I5431e741cb30541a846b65fb26aa0b7b631eb80d
alculquicondor
force-pushed
the
avoid-requeue
branch
from
1b243b3
to
40485a2
Compare
tenzen-y
reviewed
Mar 12, 2024
|
Thank you! |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c9cfce3c8804e92b9bac9ceabe7a048dd62131b0
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-0.6 |
|
@alculquicondor: new pull request created: #1832 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
vsoch
pushed a commit
to researchapps/kueue
that referenced
this pull request
Apr 18, 2024
* Avoid requeue on ClusterQueue status update Change-Id: Id028414a730a238549b7fddf5d42a2eafdf959c3 * Reclaimable pods can put pod out of inadmissible Change-Id: Id52ef3c92abd84317c4a7a71c3a20f6f28d67d25 * Delay requeueing based on RequeueState Change-Id: I5431e741cb30541a846b65fb26aa0b7b631eb80d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Kueue updates ClusterQueues to include pending or admitted workloads, among other things. These changes shouldn't trigger requeueing.
This not only saves CPU cycles, but API calls to the apiserver for Events.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?