Generalize heap implementation #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
Change-Id: Iea7c7d65a4a380a6e310099979ef3a05ecff0b75
alculquicondor
commented
Mar 8, 2024
| return heap.Pop(&h.data) | ||
| } | ||
|
|
||
| // Get returns the requested item, exists, error. |
There was a problem hiding this comment.
This function was unused.
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 6e0dbd1e4dca97eec68120dc3a968fac50b1e0fd
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vsoch
pushed a commit
to researchapps/kueue
that referenced
this pull request
Apr 18, 2024
Change-Id: Iea7c7d65a4a380a6e310099979ef3a05ecff0b75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This simplifies code, but it also opens the possibility to use the heap in other aspects, such as implementing fair-sharing algorithms #1714
Which issue(s) this PR fixes:
Fixes #217
Special notes for your reviewer:
Does this PR introduce a user-facing change?