New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add suspension to Jobset #1680
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gleichda The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Welcome @gleichda! |
Hi @gleichda. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -70,6 +70,10 @@ The first [PriorityClassName](https://kubernetes.io/docs/concepts/scheduling-evi | |||
priorityClassName: high-priority | |||
``` | |||
|
|||
### d. Suspension | |||
|
|||
You should create the JobSet in a suspended state, as Kueue will decide when it’s the best time to start the Job. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not absolutely necessary, as the Kueue's webhook would set it
jobframework.ApplyDefaultForSuspend(jobSet, w.manageJobsWithoutQueueName) |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Do you still want to update this PR to highlight the optional nature of the suspend field? |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Add suspension documentation for JobSet
Special notes for your reviewer:
Does this PR introduce a user-facing change?