Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServiceMonitor CRD should be installed first before apply prometheus.yaml #2085

Closed
1 of 3 tasks
lowang-bh opened this issue Apr 28, 2024 · 1 comment · Fixed by #2162
Closed
1 of 3 tasks

ServiceMonitor CRD should be installed first before apply prometheus.yaml #2085

lowang-bh opened this issue Apr 28, 2024 · 1 comment · Fixed by #2162
Assignees
@lowang-bh
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@lowang-bh
Copy link
Member

lowang-bh commented Apr 28, 2024 •
edited

What would you like to be added:
Note about ServiceMonitor CRD atgithub.com/prometheus-operator/kube-prometheus/manifests/setup/0servicemonitorCustomResourceDefinition.yaml should be installed first.

Why is this needed:
There is a error indicates CRDs should be installed first when follow the docs to deploy kueue,

VERSION=v0.6.2
kubectl apply --server-side -f https://github.com/kubernetes-sigs/kueue/releases/download/$VERSION/prometheus.yaml

role.rbac.authorization.k8s.io/kueue-prometheus-k8s serverside-applied
rolebinding.rbac.authorization.k8s.io/kueue-prometheus-k8s serverside-applied
error: resource mapping not found for name: "kueue-controller-manager-metrics-monitor" namespace: "kueue-system" from "https://github.com/kubernetes-sigs/kueue/releases/download/v0.6.2/prometheus.yaml": no matches for kind "ServiceMonitor" in version "monitoring.coreos.com/v1"
ensure CRDs are installed first

What's more, the same error will occur when install from source code via make promethuse

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.
@lowang-bh lowang-bh added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 28, 2024
@lowang-bh
Copy link
Member Author

/assign

@lowang-bh lowang-bh mentioned this issue May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lowang-bh lowang-bh

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

servicemonitorCRD is need before install prometheus.yaml lowang-bh/kueue
1 participant
@lowang-bh