Skip to content

Commit

Permalink
Use the setup-evnvtest version compatible with go 1.21 (#1883)
Browse files Browse the repository at this point in the history
  • Loading branch information
PBundyra committed Mar 22, 2024
1 parent 9dd55ae commit 95ecab0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Expand Up @@ -340,7 +340,7 @@ kustomize: ## Download kustomize locally if necessary.
ENVTEST = $(PROJECT_DIR)/bin/setup-envtest
.PHONY: envtest
envtest: ## Download envtest-setup locally if necessary.
@GOBIN=$(PROJECT_DIR)/bin GO111MODULE=on $(GO_CMD) install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
@GOBIN=$(PROJECT_DIR)/bin GO111MODULE=on $(GO_CMD) install sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20240320141353-395cfc7486e6

GINKGO = $(PROJECT_DIR)/bin/ginkgo
.PHONY: ginkgo
Expand Down

2 comments on commit 95ecab0

@alculquicondor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can revert this now

@tenzen-y
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you.

Please sign in to comment.