New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mods From bringing in windows userspace #336
Conversation
Followup from reading through kubernetes/kubernetes#90358 Signed-off-by: astoycos <astoycos@redhat.com>
cc @jayunit100 and @mcluseau |
Now there's a single replace directive in the window kernelspace go.mod and a few in the We should probably add CI to check if |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: astoycos, knabben The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold in favor of #333 :) Might still try to incorporate this make target |
@astoycos: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix mods after merging of windows userspace and add a make target for bumping in-tree K8s dependency versions (see kubernetes/kubernetes#90358). Short of it is we need to ensure that dep versions are fixed based on the k8s version since technically k8s/k8s isn't meant to be vendored.
Also add windows userspace to the go workspace and remove many un-necessary
replace
directives in each backend