-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support dual stack for gateway api #4469
base: master
Are you sure you want to change the base?
feat: support dual stack for gateway api #4469
Conversation
Welcome @thameezb! |
Hi @thameezb. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0d6478a
to
bd33e5e
Compare
Hi @szuecs any other comments? |
Hi I've updated the new constants to private/internal as requested. We've been dogfooding this deployment in our cluster for the last week and all looks good |
/ok-to-test |
Description
Allows for dualstack support in GatewayAPI route resources (follows existing ingress/service design paradigm)
Fixes #4468
Checklist