Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webhooks): pass webhook-* annotations to webhook providers #4458

Merged
merged 4 commits into from
May 24, 2024

Conversation

Raffo
Copy link
Contributor

@Raffo Raffo commented May 11, 2024

Description

Fixes #4367

This PR allows to forward specific implementations to webhook implementations so that they can make use of them.

@hans-m-song is this what you expected?

Checklist

  • Unit tests updated
  • End user documentation updated

Raffo and others added 3 commits April 28, 2024 14:05
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 11, 2024
@Raffo Raffo changed the title Webhook annotations Pass annotations to webhooks May 11, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 11, 2024
@mloiseleur
Copy link
Contributor

Wdyt about adding a few words about this in the documentation ?
Otherwise, lgtm.

@mloiseleur
Copy link
Contributor

I have a suggestion for the title of this PR:

feat(webhooks): pass webhook-* annotations to webhook providers

@Raffo Raffo changed the title Pass annotations to webhooks feat(webhooks): pass webhook-* annotations to webhook providers May 18, 2024
@Raffo
Copy link
Contributor Author

Raffo commented May 18, 2024

@mloiseleur yes, 100% happy to add more info. I was more wondering "is this enough" and hence why I opened it like this. I'd say that it looks enough and I'm kind of embarrassed I didn't think about it when I first worked on the webhook. Do you see anything that needs to be added for this feature to satisfy the original issue?

@Raffo
Copy link
Contributor Author

Raffo commented May 24, 2024

@mloiseleur added some docs.

@mloiseleur
Copy link
Contributor

Nope.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2024
@Raffo
Copy link
Contributor Author

Raffo commented May 24, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2024
@k8s-ci-robot k8s-ci-robot merged commit b4eea99 into kubernetes-sigs:master May 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forward additional information to webhook providers
3 participants