-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webhooks): pass webhook-* annotations to webhook providers #4458
feat(webhooks): pass webhook-* annotations to webhook providers #4458
Conversation
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
Wdyt about adding a few words about this in the documentation ? |
I have a suggestion for the title of this PR: feat(webhooks): pass webhook-* annotations to webhook providers |
@mloiseleur yes, 100% happy to add more info. I was more wondering "is this enough" and hence why I opened it like this. I'd say that it looks enough and I'm kind of embarrassed I didn't think about it when I first worked on the webhook. Do you see anything that needs to be added for this feature to satisfy the original issue? |
@mloiseleur added some docs. |
Nope. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Fixes #4367
This PR allows to forward specific implementations to webhook implementations so that they can make use of them.
@hans-m-song is this what you expected?
Checklist