-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(source/service): watch headless endpoints #4427
base: master
Are you sure you want to change the base?
feat(source/service): watch headless endpoints #4427
Conversation
Welcome @tufitko! |
Hi @tufitko. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks. This PR looks good. |
/lgtm |
|
||
// Check updates in headless endpoints. | ||
// It's ignores adds and deletes to avoid unnecessary handler processing. | ||
sc.endpointsInformer.Informer().AddEventHandler(headlessEndpointFilter{eventHandlerFunc(handler)}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather like to see an opt-in approach rather than having this added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I can add label selector to a shared informer factory, but I need to create another one, something like this:
headlessLabelSelector, err := labels.NewRequirement(v1.IsHeadlessService, selection.Exists, nil)
if err != nil {
return nil, err
}
headlessEndpointInformerFactory := kubeinformers.NewSharedInformerFactoryWithOptions(kubeClient, 0,
kubeinformers.WithNamespace(namespace),
kubeinformers.WithTweakListOptions(func(options *metav1.ListOptions) {
options.LabelSelector = headlessLabelSelector.String()
}),
)
endpointsInformer := headlessEndpointInformerFactory.Core().V1().Endpoints()
// duplicate Start and waitForCacheSync funcs for this factory
Is that OK?
Description
Call event handler for service source when headless service's endpoints change.
Fixes #4113
Checklist