Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support dual stack for gateway api #4469

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: support dual stack for gateway api #4469

wants to merge 3 commits into from

Conversation

thameezb
Copy link

@thameezb thameezb commented May 13, 2024 •
edited

Description

Allows for dualstack support in GatewayAPI route resources (follows existing ingress/service design paradigm)

Fixes #4468

Checklist

  • Unit tests updated
  • End user documentation updated

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 13, 2024 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @thameezb!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 13, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @thameezb. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign raffo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 13, 2024
@thameezb thameezb force-pushed the feat-support-dual-stack-gateway-api branch from 0d6478a to bd33e5e Compare May 13, 2024 20:41
@thameezb
Copy link
Author

thameezb commented May 14, 2024 •
edited

This was tested in a live cluster against various Gateway resources and it generates A and AAAA records as expected

image

szuecs
szuecs reviewed May 14, 2024
View reviewed changes
source/gateway.go Outdated Show resolved Hide resolved
szuecs
szuecs reviewed May 14, 2024
View reviewed changes
source/gateway.go Outdated Show resolved Hide resolved
@thameezb thameezb requested a review from szuecs May 15, 2024 12:39
@thameezb
Copy link
Author

thameezb commented May 22, 2024 •
edited

Hi @szuecs any other comments?

@thameezb
Copy link
Author

What is the update On May 22, 2024 10:04 AM, "thameezbo" @.> wrote: @szuecs https://github.com/szuecs any other comments? — Reply to this email directly, view it on GitHub <#4469 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCAXOZK5ZYZBJTN4YTLZEVDZDRNQLAVCNFSM6AAAAABHU33BHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRUGI2TCNJRGU . You are receiving this because you are subscribed to this thread.Message ID: @.>

Hi

I've updated the new constants to private/internal as requested.

We've been dogfooding this deployment in our cluster for the last week and all looks good

@mloiseleur
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers Awaiting requested review from johngmyers

@szuecs szuecs Awaiting requested review from szuecs

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for GatewayRoutes to support setting dualstack annotation
4 participants
@thameezb @k8s-ci-robot @mloiseleur @szuecs