Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward additional information to webhook providers #4367

Closed
hans-m-song opened this issue Apr 7, 2024 · 2 comments · Fixed by #4458
Closed

Forward additional information to webhook providers #4367

hans-m-song opened this issue Apr 7, 2024 · 2 comments · Fixed by #4458
Assignees
@Raffo
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@hans-m-song
Copy link

hans-m-song commented Apr 7, 2024 •
edited

What would you like to be added:

A way to forward additional information to webhook providers via annotations.

A potential solution is to add support for a wildcard annotation such as external-dns.alpha.kubernetes.io/webhook-* so that they can be exposed via ProviderSpecific here:

external-dns/source/source.go

Line 189 in 1bc6857

func getProviderSpecificAnnotations(annotations map[string]string) (endpoint.ProviderSpecific, string) {

I'm interested in any thoughts / alternate mechanisms and am open to trying my hand at raising a PR.

Why is this needed:

Given in-tree providers are being removed (#4347), the webhook mechanism will need to be more flexible to support all flags from existing providers and any new ones.

The DNSEndpoint CRD seems like it could be useful but it could be difficult to use with third-party charts that don't allow defining additional resources

(And my personal use-case #4230)

cc @Raffo, @szuecs, and @mloiseleur
@hans-m-song hans-m-song added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 7, 2024
@Raffo Raffo self-assigned this Apr 8, 2024
@Raffo
Copy link
Contributor

Raffo commented Apr 8, 2024

Assigning this myself. We're working on this plan gradually, we're not going to remove things all at once, this seems to be an important feature to add before removing the alpha providers.

@Raffo Raffo mentioned this issue May 11, 2024
Merged
2 tasks
@mloiseleur
Copy link
Contributor

@Raffo @hans-m-song Considering that:

  1. external-dns is probably more near v1.0 than when those annotations where introduced,
  2. webhook is (now) how a provider should be implemented

Wdyt of naming this annotation external-dns.kubernetes.io/webhook-* (without alpha) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Raffo Raffo

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(webhooks): pass webhook-* annotations to webhook providers Raffo/external-dns
3 participants
@Raffo @hans-m-song @mloiseleur