Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: The subject was incorrectly used in some parts of the document. #1190

Merged
merged 1 commit into from Mar 24, 2024
Merged

fix: The subject was incorrectly used in some parts of the document. #1190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/proposals/20221123-managed-kubernetes-in-capg.md
View file
Open in desktop
Expand Up @@ -107,9 +107,9 @@ So that I don't have to worry about the management of these instances

#### Functional Requirements

**FR1:** CAPA MUST support creating GKE clusters.
**FR1:** CAPG MUST support creating GKE clusters.

**FR2:** CAPA MUST validate the input an user specifies for a GKE cluster.
**FR2:** CAPG MUST validate the input an user specifies for a GKE cluster.

#### Non-Functional Requirements

Expand Down Expand Up @@ -234,7 +234,7 @@ GCP permission also needs to be updated so the controllers can call GKE APIs.

### Risks and Mitigations

The risk is that the implemented interface is different from CAPA and CAPZ. However it follows the recommended approach in the [Managed Kubernetes in CAPI](https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/proposals/20220725-managed-kubernetes.md) proposal.
The risk is that the implemented interface is different from CAPG and CAPZ. However it follows the recommended approach in the [Managed Kubernetes in CAPI](https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/proposals/20220725-managed-kubernetes.md) proposal.

## Alternatives

Expand Down