Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support additional GCPManagedControlPlane fields #1186

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

akshay196-rafay
Copy link
Contributor

@akshay196-rafay akshay196-rafay commented Mar 20, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add following GCPManagedControlPlane fields:

  • Description
  • Cluster Network
    • PrivateCluster
    • UseIPAliases
    • Pod
    • Service
  • Cluster Security
    • WorkloadIdentityConfig
    • AuthenticatorGroupConfig
    • EnableLagacyAuthorization
    • IssueClientCertificate
  • AddonsConfig
  • LoggingConfig
  • MonitoringConfig

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #906

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

TBD

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akshay196-rafay
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @akshay196-rafay. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 20, 2024
Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit 5849651
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/660a89d3f754f8000867d4cb
😎 Deploy Preview https://deploy-preview-1186--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cpanato
Copy link
Member

cpanato commented Mar 20, 2024

/ok-to-test
/test all

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 20, 2024
@akshay196-rafay akshay196-rafay force-pushed the gcpmanagedcontrolplane-additional-fields branch from f5e6b5b to 89fb7f2 Compare March 20, 2024 08:00
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2024
@akshay196-rafay akshay196-rafay force-pushed the gcpmanagedcontrolplane-additional-fields branch from 89fb7f2 to be350e5 Compare March 20, 2024 08:04
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 20, 2024
@richardcase
Copy link
Member

@akshay196-rafay - would you be able to look at the lint issues?

@akshay196-rafay akshay196-rafay force-pushed the gcpmanagedcontrolplane-additional-fields branch from be350e5 to fc5d3c3 Compare March 27, 2024 11:30
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2024
aniruddha2000 and others added 2 commits April 1, 2024 15:43
- Description
- Cluster Network
  - PrivateCluster
  - UseIPAliases
  - Pod
  - Service
- Cluster Security
  - WorkloadIdentityConfig
  - AuthenticatorGroupConfig
  - EnableLagacyAuthorization
  - IssueClientCertificate
- AddonsConfig
- LoggingConfig
- MonitoringConfig

Signed-off-by: Aniruddha Basak <codewithaniruddha@gmail.com>
Signed-off-by: Akshay Gaikwad <akshay.gaikwad@rafay.co>
Signed-off-by: Akshay Gaikwad <akshay.gaikwad@rafay.co>
@akshay196-rafay akshay196-rafay force-pushed the gcpmanagedcontrolplane-additional-fields branch from fc5d3c3 to 5849651 Compare April 1, 2024 10:17
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2024
@richardcase richardcase marked this pull request as ready for review May 7, 2024 11:09
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2024
@k8s-ci-robot k8s-ci-robot requested a review from cpanato May 7, 2024 11:09
@richardcase richardcase changed the title Support additional GCPManagedControlPlane fields [WIP] Support additional GCPManagedControlPlane fields May 7, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2024
@richardcase
Copy link
Member

/retest

@richardcase
Copy link
Member

@akshay196-rafay @aniruddha2000 - would you be able to do a make generate? Lets try and get this PR merged.

@k8s-ci-robot
Copy link
Contributor

@akshay196-rafay: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-gcp-verify 5849651 link true /test pull-cluster-api-provider-gcp-verify
pull-cluster-api-provider-gcp-apidiff 5849651 link false /test pull-cluster-api-provider-gcp-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@FrancoisKlieberOrange
Copy link

Hi @akshay196-rafay @aniruddha2000,

I hope you're doing well.

I just wanted to reach out to see if there's anything I can do to help you with it. If you're stuck on something or could use an extra set of eyes to review or troubleshoot, I'd be more than happy to assist.

Please feel free to let me know how I can support you, whether it's discussing the issue, collaborating on a solution, or just providing some feedback. I'm here to help!

Best regards,
Francois

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support additional fields for GKE
6 participants