Update node pool size even if autoscaling is enabled

[kahun]

What type of PR is this?
/kind bug

What this PR does / why we need it:
Update node pool size is disabled when autoscaling is enabled but GKE console allows to change node pool size even if autoscaling is enabled.

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

Update node pool size even if autoscaling is enabled

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kahun
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @kahun. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cpanato]

/ok-to-test

[cpanato]

my question here, is if you use cluster-api to manage your cluster you should not touch the console or change things outside the cluster-api.
what impact removing this will cause? is this a current issue?

cc @richardcase

[cpanato]

/hold

[kahun]

my question here, is if you use cluster-api to manage your cluster you should not touch the console or change things outside the cluster-api. what impact removing this will cause? is this a current issue?

cc @richardcase

That's right. The problem now is that if you have autoscaling enabled, you can't increase the size of the node pool with cluster-api. You'd have to use the console to do that.

And is even worse than that because you actually can change the number of replicas in the machine pool, so the status moves to ScalingUp but the node pool size in gke never gets the update.

[richardcase]

@cpanato @kahun - i need to try this out to see the issue. Will do that asap.

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name	Link
🔨 Latest commit	a5d8f2b
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/65f024e76726e50008a40a48
😎 Deploy Preview	https://deploy-preview-1134--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[richardcase]

@kahun - could we jump on a call to walkthrough this?

[kahun]

@kahun - could we jump on a call to walkthrough this?

Sorry for the delay, whenever you want 👍

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.