Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GKE NetworkPolicy support #1133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add GKE NetworkPolicy support #1133

wants to merge 1 commit into from

Conversation

kahun
Copy link
Contributor

@kahun kahun commented Feb 6, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add NetworkPolicy support in GCPManagedControlPlane object

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Add NetworkPolicy support in GCPManagedControlPlane object

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kahun
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @kahun. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 6, 2024
cpanato
cpanato reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 7, 2024
richardcase
richardcase reviewed Feb 7, 2024
View reviewed changes
cloud/services/container/clusters/reconcile.go Outdated Show resolved Hide resolved
exp/api/v1beta1/types.go Outdated Show resolved Hide resolved
exp/api/v1beta1/gcpmanagedcontrolplane_types.go Show resolved Hide resolved
exp/api/v1beta1/gcpmanagedcontrolplane_webhook.go Show resolved Hide resolved
@kahun kahun force-pushed the feature/add_gke_network_policy branch 2 times, most recently from 541c60e to 45088d7 Compare February 7, 2024 09:22
@kahun kahun force-pushed the feature/add_gke_network_policy branch from 45088d7 to 0800029 Compare March 12, 2024 09:38
@netlify Netlify
Copy link

netlify bot commented Mar 12, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit a41565e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/65f023c257166a0008167eef
😎 Deploy Preview https://deploy-preview-1133--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kahun kahun force-pushed the feature/add_gke_network_policy branch from 0800029 to a41565e Compare March 12, 2024 09:43
richardcase
richardcase reviewed Mar 27, 2024
View reviewed changes
Copy link
Member

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, just one comment from my side.

exp/api/v1beta1/gcpmanagedcontrolplane_types.go
// The selected network policy provider.
// +kubebuilder:validation:Enum=calico
// +optional
Provider string `json:"provider,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If NetworkPolicy is supplied by the user should we require that they supply Provider. It feels like they should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardcase richardcase richardcase left review comments

@cpanato cpanato cpanato left review comments

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kahun @k8s-ci-robot @richardcase @cpanato