New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Support additional GCPManagedControlPlane fields #1186
base: main
Are you sure you want to change the base?
[WIP] Support additional GCPManagedControlPlane fields #1186
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akshay196-rafay The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @akshay196-rafay. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test |
f5e6b5b
to
89fb7f2
Compare
89fb7f2
to
be350e5
Compare
@akshay196-rafay - would you be able to look at the lint issues? |
be350e5
to
fc5d3c3
Compare
- Description - Cluster Network - PrivateCluster - UseIPAliases - Pod - Service - Cluster Security - WorkloadIdentityConfig - AuthenticatorGroupConfig - EnableLagacyAuthorization - IssueClientCertificate - AddonsConfig - LoggingConfig - MonitoringConfig Signed-off-by: Aniruddha Basak <codewithaniruddha@gmail.com> Signed-off-by: Akshay Gaikwad <akshay.gaikwad@rafay.co>
Signed-off-by: Akshay Gaikwad <akshay.gaikwad@rafay.co>
fc5d3c3
to
5849651
Compare
/retest |
@akshay196-rafay @aniruddha2000 - would you be able to do a |
@akshay196-rafay: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Hi @akshay196-rafay @aniruddha2000, I hope you're doing well. I just wanted to reach out to see if there's anything I can do to help you with it. If you're stuck on something or could use an extra set of eyes to review or troubleshoot, I'd be more than happy to assist. Please feel free to let me know how I can support you, whether it's discussing the issue, collaborating on a solution, or just providing some feedback. I'm here to help! Best regards, |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add following GCPManagedControlPlane fields:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #906
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: