Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate annotation.md #6188

Closed

Conversation

braieralves
Copy link

Duplicate annotation: "service.beta.kubernetes.io/service.beta.kubernetes.io/azure-disable-load-balancer-floating-ip"

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Duplicate annotation: "service.beta.kubernetes.io/service.beta.kubernetes.io/azure-disable-load-balancer-floating-ip"
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 14, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 14, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @braieralves. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

netlify bot commented May 14, 2024

Deploy Preview for kubernetes-sigs-cloud-provide-azure ready!

Name Link
🔨 Latest commit 0e0c481
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/665e09fdb26e4500084437b7
😎 Deploy Preview https://deploy-preview-6188--kubernetes-sigs-cloud-provide-azure.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 14, 2024
@braieralves
Copy link
Author

/approve

@MartinForReal
Copy link
Contributor

/ok-to-test
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: braieralves, MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@MartinForReal
Copy link
Contributor

@braieralves Could you please fix the spelling error? Thanks!

@braieralves
Copy link
Author

braieralves commented Jun 3, 2024

Hello, @MartinForReal .
Sorry but this spelling error didn't come from my PR.

image

Looks like this came from #5225

What should i do, please?

Thank you

@MartinForReal
Copy link
Contributor

@nilo19 Could you please fix the spelling error? Thanks!

@nilo19
Copy link
Contributor

nilo19 commented Jun 4, 2024

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind labels Jun 4, 2024
@nilo19
Copy link
Contributor

nilo19 commented Jun 4, 2024

@braieralves can you help fix the typos reported by CI test in your PR? Thanks.

@braieralves
Copy link
Author

Hello, @nilo19
To be honest, i don't know why this error is being reported in my PR.

But this error is about this word:
image

Maybe you can change this word to the correct suggestion?
#5225

@nilo19
Copy link
Contributor

nilo19 commented Jun 4, 2024

@braieralves that's not relevant to your change, just because your PR is also about fixing a typo so I asked if you are willing to fix another one. I will file a PR to fix this. Thanks anyway.

@braieralves
Copy link
Author

@nilo19 .
I don't care to fix any other error :)

My point is, i didn't find where to do this.

Thank you

@braieralves braieralves closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants