-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resetting the client before ARM throttling happens to avoid throttling #1997
Conversation
✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for warm-cascaron-bb779f ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Welcome @chmill-zz! |
Hi @chmill-zz. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chmill-zz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -470,3 +476,11 @@ func (page DiskListPage) Values() []compute.Disk { | |||
} | |||
return *page.dl.Value | |||
} | |||
|
|||
func recreateClientChecker(response *http.Response) { | |||
needToRecrateClient := armclient.RecreateClientDueToArmLimits(response) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: recrate->recreate
@@ -470,3 +476,11 @@ func (page DiskListPage) Values() []compute.Disk { | |||
} | |||
return *page.dl.Value | |||
} | |||
|
|||
func recreateClientChecker(response *http.Response) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we extract this into util.go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think to put in this in util.go I'd need to call InitializeCloudFromConfig because I wouldn't know the client we're using at the time of the calls and just reset them all. I'm not confident on this approach or impact though. Or possibly NewCloud is better to call?
/ok-to-test |
@chmill-zz the test coverage drops a little. Is it possible to enrich it? |
/retest |
2 similar comments
/retest |
/retest |
@chmill-zz: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@chmill-zz: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
ARM throttling is different than Azure RP throttling. Described here https://docs.microsoft.com/en-us/azure/azure-resource-manager/management/request-limits-and-throttling
To avoid the instance level throttling per hour we should be able to reset the client to reset which instance we are communicating with on the ARM side. This will avoid ARM throttling.
Today we stick with the same instance and can hit throttling unnecessarily.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: