-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh/tls reload #577
base: master
Are you sure you want to change the base?
Enh/tls reload #577
Conversation
- Add fsnotify dependency to go.mod - Add file watcher for certificate files in `cmd/agent/app/server.go` and `cmd/server/app/server.go` - Reload TLS config and credentials on certificate file change in `cmd/agent/app/server.go` and `cmd/server/app/server.go` - Refactor and clean up file watcher code in `cmd/agent/app/server.go` and `cmd/server/app/server.go` Signed-off-by: Andreas Fritzler <andreas.fritzler@proton.me>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@afritzler, EasyCLA in this PR still says missing authorization; do you have ability to fix it, here? |
Ok, I think I fixed it now. Can you re-run the CLA check again? |
/retest EDIT: I think '/retest' does not retrigger the EasyCLA check... @cheftako can you look? |
@cheftako: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Performed basic rebase.