Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

Update controller.go #1594

Closed
wants to merge 1 commit into from
Closed

Conversation

wernight
Copy link
Contributor

@wernight wernight commented Aug 22, 2016

Better error message when there is no secretName provided.

Fixes #1592


This change is Reviewable

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@wernight
Copy link
Contributor Author

I signed it! (I'm a Googler)

@aledbf
Copy link
Contributor

aledbf commented Aug 22, 2016

LGTM

@bprashanth
Copy link

LGTM thanks

@bprashanth
Copy link

@wernight it didn't pick up your proclamation unfortunately, give it another shot without the suffix?

@bprashanth bprashanth added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2016
@k8s-github-robot
Copy link

@wernight PR needs rebase

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2016
@wernight
Copy link
Contributor Author

Rebased

@k8s-github-robot
Copy link

/lgtm cancel //PR changed after LGTM, removing LGTM. @bprashanth @wernight

@k8s-github-robot k8s-github-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2016
@test-foxish
Copy link

recomputing cla status...

@k8s-github-robot
Copy link

[CLA-PING] @wernight

Thanks for your pull request. It looks like this may be your first contribution to a CNCF open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://identity.linuxfoundation.org/projects/cncf to sign.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.


@k8s-github-robot k8s-github-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 22, 2016
@wernight
Copy link
Contributor Author

"I signed it!" (Googler)

@foxish
Copy link
Contributor

foxish commented Sep 23, 2016

@wernight Did you sign the CNCF CLA with your github account and Google credentials? It appears to think that you have not. If you have issues, please report them at kubernetes/kubernetes#27796

@wernight
Copy link
Contributor Author

As a Googler I cannot and shouldn't sign the CLA IMO.

@foxish
Copy link
Contributor

foxish commented Sep 24, 2016

@wernight Googlers do need to sign I think.
@sarahnovotny, can you comment on this?

@bprashanth
Copy link

@wernight are you contributing as yourself or as an employee of google? you won't be recognized as a googler unless you use your @google.com address on github/git commits.

@wernight
Copy link
Contributor Author

I don't use my @google in general for GitHub, but I also know that we're not supposed to sign CLA except a few ones. So I'm not sure how to proceed.

@bprashanth
Copy link

Ill ping you

@wernight
Copy link
Contributor Author

Performed all the steps except changing the email in the commit.

@googlebot
Copy link

CLAs look good, thanks!

@bprashanth
Copy link

i think you need to sign into the linuxfoundation thing at least once with your github account, sorry for the hoops

@bprashanth
Copy link

looks like you also need a rebase

@k8s-github-robot
Copy link

[CLA-PING] @wernight

Thanks for your pull request. It looks like this may be your first contribution to a CNCF open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://identity.linuxfoundation.org/projects/cncf to sign.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.


1 similar comment
@k8s-github-robot
Copy link

[CLA-PING] @wernight

Thanks for your pull request. It looks like this may be your first contribution to a CNCF open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://identity.linuxfoundation.org/projects/cncf to sign.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.


@k8s-github-robot
Copy link

[APPROVALNOTIFIER] The Following OWNERS Files Need Approval:

  • ingress

We suggest the following people:
cc @bprashanth
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancelin a comment

@fejta-bot
Copy link

Issues go stale after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 19, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 18, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nginx Ingress Controller not enabling TLS/HTTPS
9 participants