-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! (I'm a Googler) |
LGTM |
LGTM thanks |
@wernight it didn't pick up your proclamation unfortunately, give it another shot without the suffix? |
@wernight PR needs rebase |
Rebased |
/lgtm cancel //PR changed after LGTM, removing LGTM. @bprashanth @wernight |
recomputing cla status... |
[CLA-PING] @wernight Thanks for your pull request. It looks like this may be your first contribution to a CNCF open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://identity.linuxfoundation.org/projects/cncf to sign. Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.
|
"I signed it!" (Googler) |
@wernight Did you sign the CNCF CLA with your github account and Google credentials? It appears to think that you have not. If you have issues, please report them at kubernetes/kubernetes#27796 |
As a Googler I cannot and shouldn't sign the CLA IMO. |
@wernight Googlers do need to sign I think. |
@wernight are you contributing as yourself or as an employee of google? you won't be recognized as a googler unless you use your @google.com address on github/git commits. |
I don't use my @google in general for GitHub, but I also know that we're not supposed to sign CLA except a few ones. So I'm not sure how to proceed. |
Ill ping you |
Performed all the steps except changing the email in the commit. |
CLAs look good, thanks! |
i think you need to sign into the linuxfoundation thing at least once with your github account, sorry for the hoops |
looks like you also need a rebase |
[CLA-PING] @wernight Thanks for your pull request. It looks like this may be your first contribution to a CNCF open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://identity.linuxfoundation.org/projects/cncf to sign. Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.
|
1 similar comment
[CLA-PING] @wernight Thanks for your pull request. It looks like this may be your first contribution to a CNCF open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://identity.linuxfoundation.org/projects/cncf to sign. Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.
|
[APPROVALNOTIFIER] The Following OWNERS Files Need Approval:
We suggest the following people: |
Issues go stale after 30d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Better error message when there is no secretName provided.
Fixes #1592
This change is