Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

[wip] Break e2e tracking into its own service #1210

Closed

Conversation

eparis
Copy link
Contributor

@eparis eparis commented Jun 14, 2016

The e2e stuff has a life of its own and is too tightly coupled with the merge queue. This starts the coding to break all of the e2e stuff into its own service (which the merge queue can make use of)


This change is Reviewable

@eparis
Copy link
Contributor Author

eparis commented Jun 14, 2016

@lavalamp

# limitations under the License.

FROM google/debian:jessie
MAINTAINER Brendan Burns <bburns@google.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really? :)

@lavalamp
Copy link
Contributor

I'll look more later-- only comment so far is don't check the e2e-tests binary in :)

@eparis eparis force-pushed the display-non-blocking-seperate branch from fa916ae to cccce21 Compare June 15, 2016 01:16
@eparis eparis force-pushed the display-non-blocking-seperate branch from cccce21 to 93eb498 Compare June 15, 2016 01:16
@lavalamp
Copy link
Contributor

So I don't know if I understand the intention here-- do you want the submit queue to be looking at this second service? Or will they both be checking the tests?

(I want to make this start checking presubmit runs to file issues. I'll try to not make your rebase too hard. Alternatively if you want to split off something that does the rename & moves I could rebase on top of that?)

@eparis
Copy link
Contributor Author

eparis commented Jun 27, 2016

I intend to move all of the e2e stuff to its own daemon which the submit queue will talk to.

Everything that runs against all open PRs in one daemon. Everything that deals with the e2e tests in its own daemon. Completely decoupling the logic. More micro-servicy :)

I'd say just keep doing what you want to do. Because I don't know when I'll have time to finish that separation...

@lavalamp
Copy link
Contributor

Sounds good. Thanks!

On Mon, Jun 27, 2016 at 11:46 AM, Eric Paris notifications@github.com
wrote:

I intend to move all of the e2e stuff to its own daemon which the submit
queue will talk to.

Everything that runs against all open PRs in one daemon. Everything that
deals with the e2e tests in its own daemon. Completely decoupling the
logic. More micro-servicy :)

I'd say just keep doing what you want to do. Because I don't know when
I'll have time to finish that separation...


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1210 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAnglpbhAbftnpKc5-lUA4a97WjU2_p-ks5qQBqegaJpZM4I136W
.

@k8s-github-robot
Copy link

@eparis PR needs rebase

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 17, 2016
@test-foxish
Copy link

recomputing cla status...

@k8s-github-robot
Copy link

[CLA-PING] @eparis

Thanks for your pull request. It looks like this may be your first contribution to a CNCF open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://identity.linuxfoundation.org/projects/cncf to sign.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.


@k8s-github-robot k8s-github-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 22, 2016
@eparis
Copy link
Contributor Author

eparis commented Sep 23, 2016

@foxish who owns setting the cla/linuxfoundation ? It's getting me wrong (and who knows how many other Red Hatters) so I want to know who to talk with...

@foxish
Copy link
Contributor

foxish commented Sep 23, 2016

@eparis, could you explain on kubernetes/kubernetes#27796? @caniszczyk should be able to help out.

@emsearcy
Copy link

emsearcy commented Sep 23, 2016

Bump (signed it?). (edit: worked, cla/linuxfoundation no->yes)

@k8s-github-robot k8s-github-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 23, 2016
@eparis eparis closed this Dec 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/mungegithub cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants