delete the content if creation failed and snapshot deleted

[huww98]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:

This is useful for Retain policy snapshot. When volume snapshot is created with invalid config, then deleted, all things should be cleaned up, instead of leaving a content to retry creation infinitely.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Some cleanups are included, please see commit message.

A new RBAC permission is added.

Does this PR introduce a user-facing change?:

No retry of creation is performed after the VolumeSnapshot is deleted.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: huww98
Once this PR has been reviewed and has the lgtm label, please assign saad-ali for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @huww98!

It looks like this is your first PR to kubernetes-csi/external-snapshotter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-snapshotter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @huww98. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[huww98]

/cc @xing-yang
as I see your NOTE in comment. And you also appear in git blame

[huww98]

I think we should always do expectSuccess: true? Specify false means don't check for failure, not asserting error is returned. But that is a big project. Let's leave it to another PR.

[xing-yang]

What is the reason to remove this whole block?

[huww98]

external-snapshotter/pkg/common-controller/snapshot_controller.go

Lines 332 to 337 in 3a35a5e

	// regardless of the deletion policy, set the VolumeSnapshotBeingDeleted on
	// content object, this is to allow snapshotter sidecar controller to conduct
	// a delete operation whenever the content has deletion timestamp set.
	if content != nil {
	klog.V(5).Infof("checkandRemoveSnapshotFinalizersAndCheckandDeleteContent[%s]: Set VolumeSnapshotBeingDeleted annotation on the content [%s]", utils.SnapshotKey(snapshot), content.Name)
	updatedContent, err := ctrl.setAnnVolumeSnapshotBeingDeleted(content)

This code should already handle it.

In the commit message of second commit, I wrote:

The original annotate logic in syncContent() is not needed because all deleting snapshot will go through above logic. And natually, if a content is never bound, is will never get the vs-deleted annotation.

[huww98]

Hi @xing-yang What do you think about the overall direction of this PR? Should we continue to work on this? These change is not required for this PR. If you agree, I can defer it to another PR.