charts: fix master and control-plane nodeSelectors

[intelfx]

What type of PR is this?
/kind bug

What this PR does / why we need it:

controller.runOnMaster and controller.runOnControlPlane are non-functional as written, since an empty value in a nodeSelector is not treated as a wildcard. Fix the nodeSelectors to match against "true", which is enough to successfully schedule the controller on a master/control-plane node in my testing.

Does this PR introduce a user-facing change?:

none

[k8s-ci-robot]

Welcome @intelfx!

It looks like this is your first PR to kubernetes-csi/csi-driver-nfs 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-nfs has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @intelfx. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: intelfx
Once this PR has been reviewed and has the lgtm label, please assign saad-ali for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andyzhangx]

not sure whether all master node are labeled with node-role.kubernetes.io/control-plane: "", but as I know, the azure capz cluster are labeled as node-role.kubernetes.io/control-plane: ""

[andyzhangx]

I think you could set set --nodeSelector=xxx to make it work on your testing env if existing config does not work on your testing env.

[intelfx]

I can, but it's a footgun. Also, as I remember, at least GKE also has "true" instead of "".

Would you be open to a patch that replaces these node selector with node affinities (which make it possible to declare an "Exists" relation instead of a strict match)?

[andyzhangx]

yes, check exists is better than strict match, thanks.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale