Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Francisco as OWNER for Feature Store documentation #3731

Merged
merged 1 commit into from May 12, 2024

Conversation

franciscojavierarceo
Copy link
Contributor

@franciscojavierarceo franciscojavierarceo commented May 4, 2024

I am one of the maintainers of Feast and I'd like to update the documentation here.

So I have proposed to add myself as an OWNER for the Feature Store documentation.

Copy link

Hi @franciscojavierarceo. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
@franciscojavierarceo
Copy link
Contributor Author

@andreyvelich @woop

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@franciscojavierarceo
Copy link
Contributor Author

@Arhell any update here?

@Arhell
Copy link
Member

Arhell commented May 7, 2024

Sorry, I don't have approval rights

@franciscojavierarceo
Copy link
Contributor Author

franciscojavierarceo commented May 7, 2024

Np I also added a separate PR to add me to the org here: kubeflow/internal-acls#679

@woop
Copy link
Member

woop commented May 9, 2024

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@franciscojavierarceo
Copy link
Contributor Author

@johnugeorge any chance you can review?

@rimolive
Copy link
Member

/lgtm

@rimolive
Copy link
Member

/verify-owners

@google-oss-prow google-oss-prow bot merged commit 2b580ed into kubeflow:master May 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants