Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Gsoc Expcted Outcome #3685

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Ayush9026
Copy link

Solve this Issue added GSoC Outcome of all projects #3673

So GSoC Google reviewers can access all information.

Copy link

Hi @Ayush9026. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this @Ayush9026!
/ok-to-test
/assign @johnugeorge @tenzen-y @rareddy @juliusvonkohout @thesuperzapper @kimwnasptd for the review

content/en/events/gsoc-2024.md Outdated Show resolved Hide resolved
@andreyvelich
Copy link
Member

Please can you sign your commit for DCO ?

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding Katib and Training-Operator, LGTM

Signed-off-by: Ayush Gupta <guptaayush9040@gmail.com>
@Ayush9026
Copy link
Author

Ayush9026 commented Feb 21, 2024

@andreyvelich sir signed commit for DCO.

Correct formatting : Added space after colon

Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@andreyvelich
Copy link
Member

andreyvelich commented Feb 21, 2024

@andreyvelich sir signed commit for DCO.

@Ayush9026 I think, you should sign second commit for both of us.
Otherwise, you can try to squash these 2 commits to one and just sign it: git commit -s -m "Added GSOC Expected Outcome"

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ayush9026
Once this PR has been reviewed and has the lgtm label, please assign james-jwu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Ayush Gupta <guptaayush9040@gmail.com>
@juliusvonkohout
Copy link
Member

Hello, I think it is istio-cni and istio ambient mesh, not just the ambient mesh.

@thesuperzapper
Copy link
Member

Personally, I think the descriptions that are already there probably give enough context to prospective students.

We don't want students being scared off because they think they need to implement the entire thing by themselves. Most of your proposed "expected outcomes" claim the project is about solving the overall problem, rather than just participating in some specific way.

For almost all projects, the "expected outcome" is something smaller, like: "you will support the implementation of bigger project yyyyy by delivering xxxxx".

@thesuperzapper
Copy link
Member

Also, I am highly suspicious of this PR, as it is clearly trying to hide something (see the strange e -i HEAD~2 addition in the diff, which GitHub can't view).

I am holding for security review.

/hold

@Ayush9026
Copy link
Author

@thesuperzapper sir e -i HEAD~2 is by mistakely i will remove it . I completely understand the need for a thorough security review. Please let me know if there's any additional information or assistance I can provide during this process.

@tenzen-y
Copy link
Member

@thesuperzapper sir e -i HEAD~2 is by mistakely i will remove it . I completely understand the need for a thorough security review. Please let me know if there's any additional information or assistance I can provide during this process.

@Ayush9026 I guess that once you squash all commits into one, all DOC errors are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants