Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(icon): Update to new twitter logo #3636

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

venkyvajrala
Copy link

Fixes: #3633

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: venkyvajrala
Once this PR has been reviewed and has the lgtm label, please assign shannonbradshaw for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Hi @venkyvajrala. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thesuperzapper
Copy link
Member

@venkyvajrala why did you update docsy in this PR?

Also, updating docsy is way more complex than just updating the submodule.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@venkyvajrala
Copy link
Author

@thesuperzapper
it has dependency on docsy font-awesome package version. Twitter logo doesn't appear if we don't update the package version of font-awesome to 6.4.2 .I made the change in docsy repo and added the commit which has 6.4.2 package version for font-awesome library.
Please let me know if I am missing anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stale Twitter icon
3 participants