Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: no overwrite when run launcher as worker #628

Merged
merged 2 commits into from Mar 4, 2024

Conversation

kuizhiqing
Copy link
Member

Default implementation overwrite envs NVIDIA_VISIBLE_DEVICES and NVIDIA_DRIVER_CAPABILITIES which is not work in the RunLauncherAsWorker case with GPU.

Signed-off-by: kuizhiqing <kuizhiqing@msn.com>
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation is lgtm
Could you extend unit tests here?:

func TestNewLauncherAndWorker(t *testing.T) {

Signed-off-by: kuizhiqing <kuizhiqing@msn.com>
@google-oss-prow google-oss-prow bot added size/L and removed size/S labels Mar 4, 2024
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/assign @alculquicondor

Copy link
Collaborator

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 942a20a into kubeflow:master Mar 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants