fix: incorrect references DASHBOARD_LINKS_CONFIGMAP env-var

[hhk7734]

fix env name mismatch

kubeflow/components/centraldashboard/app/k8s_service.ts

Lines 4 to 7 in d1c40f9

	const {
	DASHBOARD_CONFIGMAP = "centraldashboard-config",
	LOGOUT_URL = '/logout'
	} = process.env;

kubeflow/components/centraldashboard-angular/backend/app/k8s_service.ts

Lines 4 to 9 in d1c40f9

	const {
	DASHBOARD_CONFIGMAP = "centraldashboard-config",
	KF_DASHBOARD_BUILD_LABEL = "Build",
	KF_DASHBOARD_VERSION = null,
	KF_DASHBOARD_BUILD_ID = null,
	} = process.env;

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[kimwnasptd]

@hhk7734 thanks for the PR!

Looking at this code again, isn't the current DASHBOARD_CONFIGMAP value hardcoded in the backend? This means that even if we change the name of the ENV var in the pod, then this still won't get picked up

[hhk7734]

@hhk7734 thanks for the PR!

Looking at this code again, isn't the current DASHBOARD_CONFIGMAP value hardcoded in the backend? This means that even if we change the name of the ENV var in the pod, then this still won't get picked up

@kimwnasptd
Could you let me know where is the hardcoded line?

or, did you point out the below code?

kubeflow/components/centraldashboard-angular/backend/app/k8s_service.ts

Lines 4 to 9 in d1c40f9

	const {
	DASHBOARD_CONFIGMAP = "centraldashboard-config",
	KF_DASHBOARD_BUILD_LABEL = "Build",
	KF_DASHBOARD_VERSION = null,
	KF_DASHBOARD_BUILD_ID = null,
	} = process.env;

the above code is not hardcoded, just declare default values.

Welcome to Node.js v18.15.0.
Type ".help" for more information.
> process.env
{
  // ...
  SHELL: '/usr/bin/zsh',
  // ...
}
> const { SHELL = "hi" } = process.env
undefined
> SHELL
'/usr/bin/zsh'
> 

[thesuperzapper]

@kimwnasptd, @hhk7734 is correct, the env var was randomly renamed by #5469 from DASHBOARD_LINKS_CONFIGMAP to DASHBOARD_CONFIGMAP.

So we need to rebase and merge this.

[thesuperzapper]

@hhk7734 the failing tests are not related to this PR, once we merge #7578 they should pass (if you rebase).

[thesuperzapper]

@hhk7734 thanks so much for this, sorry about the delay.

We will include this in the default manifest for 1.9.0-rc.0.

/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/centraldashboard/OWNERS [thesuperzapper]
• components/centraldashboard-angular/OWNERS [thesuperzapper]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment