Skip to content

Commit

Permalink
docs: update example notebooks spec (#7107)
Browse files Browse the repository at this point in the history
It looks like the notebook images no longer rely on start.sh.

It looks like the Docker images now use the init system to run jupyterlab with the correct arguments
https://github.com/kubeflow/kubeflow/blob/master/components/example-notebook-servers/jupyter/Dockerfile

I could find no start.sh script in the repo
  • Loading branch information
jlewi committed May 13, 2024
1 parent bd7f250 commit 7092541
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions components/notebook-controller/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,6 @@ spec:
containers:
- name: my-notebook
image: kubeflownotebookswg/jupyter:master
args:
[
"start.sh",
"lab",
"--LabApp.token=''",
"--LabApp.allow_remote_access='True'",
"--LabApp.allow_root='True'",
"--LabApp.ip='*'",
"--LabApp.base_url=/test/my-notebook/",
"--port=8888",
"--no-browser",
]
```

The required fields are `containers[0].image` and (`containers[0].command` and/or `containers[0].args`).
Expand Down

0 comments on commit 7092541

Please sign in to comment.