Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get kserve job panic #1086

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

Syulin7
Copy link
Collaborator

@Syulin7 Syulin7 commented May 13, 2024

/kind bugfix

Run command serve get qwen --type kserve

Output errors:

github.com/kubeflow/arena/pkg/serving.(*servingJob).GetLabels(...)
        /Users/baizi/Documents/code/src/github.com/kubeflow/arena/pkg/serving/serving.go:321
github.com/kubeflow/arena/pkg/apis/arenaclient.(*ServingJobClient).GetAndPrint(0x14000c8fbc0, {0x16efeb584, 0x4}, {0x0, 0x0}, {0x10263e759, 0x6}, {0x10263c896, 0x4})
        /Users/baizi/Documents/code/src/github.com/kubeflow/arena/pkg/apis/arenaclient/serving_client.go:90 +0x310
github.com/kubeflow/arena/pkg/commands/serving.NewGetCommand.func2(0x1400029c800?, {0x14000983bf0?, 0x4?, 0x10263c8c2?})
        /Users/baizi/Documents/code/src/github.com/kubeflow/arena/pkg/commands/serving/get.go:60 +0x244
github.com/kubeflow/arena/vendor/github.com/spf13/cobra.(*Command).execute(0x140008da008, {0x14000983b90, 0x3, 0x3})
        /Users/baizi/Documents/code/src/github.com/kubeflow/arena/vendor/github.com/spf13/cobra/command.go:940 +0x654
github.com/kubeflow/arena/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x14000434c08)
        /Users/baizi/Documents/code/src/github.com/kubeflow/arena/vendor/github.com/spf13/cobra/command.go:1068 +0x320
github.com/kubeflow/arena/vendor/github.com/spf13/cobra.(*Command).Execute(0x1400008c6f8?)
        /Users/baizi/Documents/code/src/github.com/kubeflow/arena/vendor/github.com/spf13/cobra/command.go:992 +0x1c
main.main()
        /Users/baizi/Documents/code/src/github.com/kubeflow/arena/cmd/arena/main.go:63 +0x300

Signed-off-by: Syulin7 <735122171@qq.com>
Copy link

@Syulin7: The label(s) kind/bugfix cannot be applied, because the repository doesn't have them.

In response to this:

/kind bugfix

Run command serve get qwen --type kserve

Output errors:

github.com/kubeflow/arena/pkg/serving.(*servingJob).GetLabels(...)
       /Users/baizi/Documents/code/src/github.com/kubeflow/arena/pkg/serving/serving.go:321
github.com/kubeflow/arena/pkg/apis/arenaclient.(*ServingJobClient).GetAndPrint(0x14000c8fbc0, {0x16efeb584, 0x4}, {0x0, 0x0}, {0x10263e759, 0x6}, {0x10263c896, 0x4})
       /Users/baizi/Documents/code/src/github.com/kubeflow/arena/pkg/apis/arenaclient/serving_client.go:90 +0x310
github.com/kubeflow/arena/pkg/commands/serving.NewGetCommand.func2(0x1400029c800?, {0x14000983bf0?, 0x4?, 0x10263c8c2?})
       /Users/baizi/Documents/code/src/github.com/kubeflow/arena/pkg/commands/serving/get.go:60 +0x244
github.com/kubeflow/arena/vendor/github.com/spf13/cobra.(*Command).execute(0x140008da008, {0x14000983b90, 0x3, 0x3})
       /Users/baizi/Documents/code/src/github.com/kubeflow/arena/vendor/github.com/spf13/cobra/command.go:940 +0x654
github.com/kubeflow/arena/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x14000434c08)
       /Users/baizi/Documents/code/src/github.com/kubeflow/arena/vendor/github.com/spf13/cobra/command.go:1068 +0x320
github.com/kubeflow/arena/vendor/github.com/spf13/cobra.(*Command).Execute(0x1400008c6f8?)
       /Users/baizi/Documents/code/src/github.com/kubeflow/arena/vendor/github.com/spf13/cobra/command.go:992 +0x1c
main.main()
       /Users/baizi/Documents/code/src/github.com/kubeflow/arena/cmd/arena/main.go:63 +0x300

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gujingit
Copy link
Contributor

/approve
/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gujingit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit a031bae into kubeflow:master May 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants