Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump artifact action version to v4 #5603

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ErikJiang
Copy link

What type of PR is this?
/kind feature

What this PR does / why we need it:

The artifact-related action version has been updated to v4, and dependabot has been added to perform a weekly check for updates to the action version in workflows. If the bot detects that an action version is outdated, it will automatically submit a pull request for updating the version.

Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
@kubeedge-bot kubeedge-bot added the kind/feature Categorizes issue or PR as related to a new feature. label May 12, 2024
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign sids-b after the PR has been reviewed.
You can assign the PR to them by writing /assign @sids-b in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot
Copy link
Collaborator

Welcome @ErikJiang! It looks like this is your first PR to kubeedge/kubeedge 🎉

@kubeedge-bot kubeedge-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 12, 2024
Copy link
Contributor

@wbc6080 wbc6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the reason for upgrading the version because the original version will be deprecated, or because there are some bugs?

@ErikJiang
Copy link
Author

@wbc6080 I noticed that the artifact component has relevant deprecation warnings.

image image

@ErikJiang
Copy link
Author

@chendave @fisherxu PTAL 😊

Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some warning like:
image

Shouldn't they be upgraded together?

@ErikJiang
Copy link
Author

@Shelley-BaoYue 😀 I believe we can entrust the task of updating the next version of the action to Dependabot. However, if you think it's necessary, I can also take care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants