Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudhub enhancement #5585

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

spambot000
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Enhance access control of CloudHub API

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

1. Some edge nodes with older version certificates may not be authenticated by cloudcore if this feature is turned on.

@kubeedge-bot kubeedge-bot added the kind/documentation Categorizes issue or PR as related to documentation. label May 3, 2024
@kubeedge-bot kubeedge-bot requested review from fisherxu and gy95 May 3, 2024 16:03
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign qizha after the PR has been reviewed.
You can assign the PR to them by writing /assign @qizha in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 3, 2024
@spambot000 spambot000 force-pushed the cloudhub_enhance branch 3 times, most recently from 8615bb2 to cfb7c95 Compare May 4, 2024 02:09
Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you need to update vendor, you should update go.mod file and then execute hack/update-vendor.sh and update-vendor-license.sh.

@spambot000 spambot000 force-pushed the cloudhub_enhance branch 3 times, most recently from de711eb to 3fdaf49 Compare May 26, 2024 10:55
@spambot000
Copy link
Contributor Author

@Shelley-BaoYue I've updated the package authorization and added some test cases.

Signed-off-by: spambot000 <jkjkjk0306@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants