Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal:Keadm Tool Enhancement #5574

Merged
merged 10 commits into from
May 22, 2024
Merged

Conversation

HT0403
Copy link
Contributor

@HT0403 HT0403 commented Apr 28, 2024

What type of PR is this?
/kind design

What this PR does / why we need it:
Keadm(KubeEdge installation tool) now only supports configuring a subset of parameters during EdgeCore installation. We would like to support specifying parameters using --set or directly using an existing local configuration file to achieve full parameter configuration and meet the users' requirements.
Which issue(s) this PR fixes:

Fixes #5563

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: HT0403 <ht000229@qq.com>
Signed-off-by: HT0403 <ht000229@qq.com>
@kubeedge-bot kubeedge-bot added kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 28, 2024
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @WillardHu

@WillardHu
Copy link
Collaborator

Add some design contents about how to add a flag set to the keadm and applied to the edgecore config.

Signed-off-by: HT0403 <ht000229@qq.com>
@kubeedge-bot kubeedge-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 15, 2024
docs/proposals/Keadm Tool Enhancement.md Outdated Show resolved Hide resolved
docs/proposals/Keadm Tool Enhancement.md Outdated Show resolved Hide resolved
docs/proposals/Keadm Tool Enhancement.md Outdated Show resolved Hide resolved
Signed-off-by: HT0403 <ht000229@qq.com>
@kubeedge-bot kubeedge-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 15, 2024
Signed-off-by: HT0403 <ht000229@qq.com>
Signed-off-by: HT0403 <ht000229@qq.com>
Signed-off-by: HT0403 <ht000229@qq.com>
Signed-off-by: HT0403 <ht000229@qq.com>
Signed-off-by: HT0403 <ht000229@qq.com>
Signed-off-by: HT0403 <ht000229@qq.com>
@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2024
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WillardHu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2024
@kubeedge-bot kubeedge-bot merged commit 04eb67d into kubeedge:master May 22, 2024
17 checks passed
@WillardHu
Copy link
Collaborator

Sorry, I approve my request changes, but the label approved have been added... 😂

@fisherxu
Copy link
Member

Sorry, I approve my request changes, but the label approved have been added... 😂

All right, if there's any issue, just fix it in follow up PRs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keadm Tool Enhancement
4 participants