Proposal: Image PrePull Feature Enhancement #5567
Conversation
kubeedge-bot
added
the
kind/feature
|
Welcome @hyp4293! It looks like this is your first PR to kubeedge/kubeedge 🎉 |
kubeedge-bot
added
the
size/L
Signed-off-by: hyp4293 <429302517@qq.com>
hyp4293
force-pushed
the
topic2imageprepull
branch
from
2728ab3
to
41eea1d
Compare
Shelley-BaoYue
changed the title
Shelley-BaoYue
changed the title
There was a problem hiding this comment.
for the proposal images:
- Don't use Chinese
- Please differentiate between the proposal and usage guide. For example, how to generate a secret and how to manually pull an image do not need to be described in the proposal.
- Please describe the override content in the image.
| @@ -0,0 +1,252 @@ | |||
| # Image PrePulling Feature Enhancement | |||
There was a problem hiding this comment.
Please add header at the top of proposal like:
|
|
||
| ### Goals | ||
|
|
||
| In the previous version, each task execution currently only supports images from the same image warehouse, and only supports the configuration of one secret. Now, we will enhance this function, which will support covering images and secrets, and can configure multiple secrets to pull images from multiple warehouses. |
There was a problem hiding this comment.
This should be motivation but not Goals. The format of the goals is generally similar to "support configure multiple secret in one imagepulljob"
|
|
||
| ### Architecture | ||
|
|
||
|  |
There was a problem hiding this comment.
It is not friendly to add Chinese in documents of the community, including the Chinese in the design image.
|
|
||
|
|
||
|
|
||
| ### override manager |
There was a problem hiding this comment.
What is override manager? Is it a module? What the capability of override manager and which fields can be overridden by the overmanager?
|
|
||
| ``` | ||
|
|
||
| Kubectl Secret |
There was a problem hiding this comment.
How to generate secrets is a common function of Kubernetes and does not need to be described in the proposal, including the design diagram.
|
|
||
|
|
||
|
|
||
| ### Image PrePull API |
There was a problem hiding this comment.
Don't need to list all the existing APIs. Focus on what you've added or modified in this feature.
| // ImagePrePullTemplate represents original templates of imagePrePull | ||
| ImagePrePullTemplate ImagePrePullTemplate `json:"imagePrePullTemplate,omitempty"` | ||
|
|
||
| // ImagePrePullScope represents the override rules that would apply on imagePrePull job. |
There was a problem hiding this comment.
I don't see your definition of override api.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Image PrePull Feature Enhancement
In the latest release, KubeEdge has implemented the ability for image pre pull. However, each task execution only supports images from the same image repository currently. We hope to enhance this feature to support capabilities like overriding images and secrets, complete end-to-end tests for this feature.
#5341